Pin Saorsa dependencies to stability-improvements branches#93
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR switches ant-protocol and saorsa-core from crates.io releases to git branch pins (fix/stability-improvements) and refreshes Cargo.lock to reflect the new resolution (including updated transitive dependencies and a matching git-sourced saorsa-transport).
Changes:
- Pin
ant-protocolandsaorsa-coretofix/stability-improvementsbranches via git dependencies. - Update
Cargo.lockto capture the resulting git sources and transitive dependency updates.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Cargo.toml | Replaces crates.io version dependencies with git branch pins for ant-protocol and saorsa-core. |
| Cargo.lock | Updates resolved dependency graph to include git sources and transitive version bumps/removals. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+36
to
+39
| ant-protocol = { git = "https://github.com/WithAutonomi/ant-protocol", branch = "fix/stability-improvements" } | ||
|
|
||
| # Core (provides EVERYTHING: networking, DHT, security, trust, storage) | ||
| saorsa-core = "0.24.2" | ||
| saorsa-core = { git = "https://github.com/saorsa-labs/saorsa-core", branch = "fix/stability-improvements" } |
Comment on lines
+32
to
+36
| @@ -33,10 +33,10 @@ path = "src/bin/ant-devnet/main.rs" | |||
| # Until then, the git pin tracks the matching saorsa-core lineage | |||
| # (the rc-2026.4.2 branch) so Cargo can unify the wire types here | |||
| # with ant-protocol's re-exports. | |||
| ant-protocol = "2.0.3" | |||
| ant-protocol = { git = "https://github.com/WithAutonomi/ant-protocol", branch = "fix/stability-improvements" } | |||
mickvandijke
force-pushed
the
fix/stability-improvements
branch
2 times, most recently
from
0865750 to
4920a47
Compare
Comment on lines
+32
to
+36
| @@ -33,10 +33,10 @@ path = "src/bin/ant-devnet/main.rs" | |||
| # Until then, the git pin tracks the matching saorsa-core lineage | |||
| # (the rc-2026.4.2 branch) so Cargo can unify the wire types here | |||
| # with ant-protocol's re-exports. | |||
| ant-protocol = "2.0.3" | |||
| ant-protocol = { git = "https://github.com/WithAutonomi/ant-protocol", branch = "fix/stability-improvements" } | |||
Comment on lines
+36
to
+39
| ant-protocol = { git = "https://github.com/WithAutonomi/ant-protocol", branch = "fix/stability-improvements" } | ||
|
|
||
| # Core (provides EVERYTHING: networking, DHT, security, trust, storage) | ||
| saorsa-core = "0.24.2" | ||
| saorsa-core = { git = "https://github.com/saorsa-labs/saorsa-core", branch = "fix/stability-improvements" } |
grumbach
approved these changes
May 12, 2026
Collaborator
grumbach
left a comment
grumbach
left a comment
There was a problem hiding this comment.
Approving. The pinned saorsa-transport / saorsa-core / ant-protocol stability branches built and ran cleanly on my 210-node 7-region anselme-testnet 2026-05-12. Storer-side Merkle payment verified fires per chunk, no unexpected protocol errors, no panics on the stability-bundle code paths.
This is #4 in the merge chain (transport -> core -> protocol -> node -> client). Should ideally land alongside ant-client#78 to keep the cross-repo pins consistent.
Semver: patch
After rebase onto upstream main, the WithAutonomi/ant-protocol fix/stability-improvements branch (f3b5a9d) was stale: PR #6 (the ChunkPutRequest content: Bytes perf change) had since been merged into ant-protocol main (93e63b8), but the topic branch tip was not advanced. Our handler / e2e call sites already expect the Bytes-typed field, so building against the stale branch failed. - Point the direct ant-protocol dep at the ant-protocol `main` branch, which now contains both the transport_source ignore fix and the Bytes-perf change. - Update [patch.crates-io] ant-protocol to the same branch. - Add a [patch.crates-io] saorsa-core entry so transitive crates that pull saorsa-core 0.24.2 from crates.io unify with our direct git branch pin, avoiding two saorsa-core versions in the graph (which splits the MultiAddr / DHT types and breaks ant-devnet). - Drop the now-redundant [patch."https://github.com/WithAutonomi/ant-protocol"] table; patching a git source to itself is rejected by Cargo, and the crates.io patch is sufficient once the direct dep already points at the target branch. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jacderida
force-pushed
the
fix/stability-improvements
branch
from
8e415da to
4dfc4a2
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
Cargo.toml:184
- The PR description says ant-protocol is pinned to the
fix/stability-improvementsbranch, but this patch (and the direct dependency above) pins ant-protocol tobranch = "main". Please align the pinned branch with the PR intent (or update the PR description/comments accordingly).
[patch.crates-io]
ant-protocol = { git = "https://github.com/WithAutonomi/ant-protocol", branch = "main" }
saorsa-core = { git = "https://github.com/saorsa-labs/saorsa-core", branch = "fix/stability-improvements" }
Comment on lines
34
to
35
| # (the rc-2026.4.2 branch) so Cargo can unify the wire types here | ||
| # with ant-protocol's re-exports. |
| # (the rc-2026.4.2 branch) so Cargo can unify the wire types here | ||
| # with ant-protocol's re-exports. | ||
| ant-protocol = "2.0.3" | ||
| ant-protocol = { git = "https://github.com/WithAutonomi/ant-protocol", branch = "main" } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing