-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Privacy: Reset wp_page_for_privacy_policy when the page is trashed or deleted #11443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
masteradhoc
wants to merge
14
commits into
WordPress:trunk
Choose a base branch
from
masteradhoc:56694-uncached-database-reads
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
869faa0
add _reset_privacy_policy_page_for_post function
masteradhoc e5745b5
add actions
masteradhoc 6b3e05b
add reset option
masteradhoc 3930d1c
Removed the "page is in trash" error
masteradhoc e391d36
add feedback of mukesh
masteradhoc f4dfb44
add feedback of mukesh
masteradhoc 555e5c6
Fix whitespace
masteradhoc 47d48d6
fix phpstan error
masteradhoc beb4349
add westons feedback
masteradhoc fbf18e4
remove redundant code
masteradhoc f8e9ddb
add unit tests
masteradhoc d398eeb
upgrade failing test
masteradhoc ccfd7f2
update test
masteradhoc 49426c4
fix tests
masteradhoc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In practice, would this logic ever run now? Considering that the
wp_page_for_privacy_policyoption is set to0whenever the policy page is trashed or deleted, this condition would seem to just be here for extreme defensive programming. It doesn't seem necessary though.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@westonruter as far as i tested back then it was added so also existing websites where the privacy policy page was deleted it gets catched after the patch has been added. for websites deleting pages after the patch your right this will not be needed.