Reusable admin CSS for destructive actions#11519
Open
vishalsingh098 wants to merge 1 commit intoWordPress:trunkfrom
Open
Reusable admin CSS for destructive actions#11519vishalsingh098 wants to merge 1 commit intoWordPress:trunkfrom
vishalsingh098 wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @vishal-xecurify. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/36882
Here's a summary of what was changed:
CSS (source):
[css/colors/_admin.scss] — added .wp-core-ui .delete-link to both the base and hover/focus destructive color rules alongside .button-link-delete
[css/common.css] — added a standalone .delete-link rule (with hover/focus) for use outside .wp-core-ui contexts, with a doc comment explaining it's for plugin/theme authors
PHP (15 locations — all existing destructive links got delete-link added to their class list):
[class-wp-posts-list-table.php] — trash & delete permanently links
[class-wp-comments-list-table.php] — delete & trash links
[class-wp-users-list-table.php] — delete & remove links
[class-wp-terms-list-table.php] — delete tag link
[class-wp-links-list-table.php] — delete link
[class-wp-media-list-table.php] — untrash, trash, delete links
[class-wp-themes-list-table.php] — delete theme link
[class-walker-nav-menu-edit.php] — nav menu item delete
[meta-boxes.php] — move to trash / delete permanently / link delete (3 places)
[post.php] — remove featured image link
[edit-tag-form.php] — delete tag link
[edit-form-comment.php] — comment delete/trash link
[nav-menus.php] — delete menu link
Use of AI Tools
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.