Skip to content

$_GET['pagenow'] and $_GET['widget'] unsanitized in dashboard AJAX handler #11540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rajeshcpr wants to merge 3 commits into
base: trunk
Choose a base branch
from
+3 −2
Open

$_GET['pagenow'] and $_GET['widget'] unsanitized in dashboard AJAX handler #11540

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8aca2e
$_GET['pagenow'] and $_GET['widget'] unsanitized in dashboard AJAX ha…
rajeshcpr Apr 9, 2026
923e035
Merge branch 'trunk' into rajeshcpr-patch-5
rajeshcpr Apr 9, 2026
19f3335
Merge branch 'trunk' into rajeshcpr-patch-5
rajeshcpr Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/wp-admin/includes/ajax-actions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,12 +420,13 @@ function wp_ajax_get_community_events() {
function wp_ajax_dashboard_widgets() {
require_once ABSPATH . 'wp-admin/includes/dashboard.php';

$pagenow = $_GET['pagenow'];
$pagenow = isset( $_GET['pagenow'] ) ? sanitize_key( $_GET['pagenow'] ) : '';
Copy link
Copy Markdown
Member

@mukeshpanchal27 mukeshpanchal27 Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$pagenow = isset( $_GET['pagenow'] ) ? sanitize_key( $_GET['pagenow'] ) : '';
$pagenow = sanitize_key( $_GET['pagenow'] ?? '' );

if ( 'dashboard-user' === $pagenow || 'dashboard-network' === $pagenow || 'dashboard' === $pagenow ) {
set_current_screen( $pagenow );
}

switch ( $_GET['widget'] ) {
$widget = isset( $_GET['widget'] ) ? sanitize_key( $_GET['widget'] ) : '';
Copy link
Copy Markdown
Member

@mukeshpanchal27 mukeshpanchal27 Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$widget = isset( $_GET['widget'] ) ? sanitize_key( $_GET['widget'] ) : '';
$widget = sanitize_key( $_GET['widget'] ?? '' );

switch ( $widget ) {
case 'dashboard_primary':
wp_dashboard_primary();
break;
Expand Down
Loading