Fix: Update composer.json to run the test suites#259
Open
hbhalodia wants to merge 1 commit into
Open
Conversation
Author
|
Hi @dmsnell, Have updated the composer dependencies and its working as expected. The only tests are failing because of compatibility issue for PHPUnit version and WP compatibility. I have tried multiple things in PR - #258, But was unable to resolve the test failures, but yes have resolved the issue with composer.json which were not installed as per the comment - #254 (comment) Let me know if we can move forward with this, merge and rebase the PR - #254? Or to fix the test, what can be done to resolve unit test with less than WP 5.7 version added in tests.yml? should we skip those, remove or is there any alternatives? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doctrine/instantiatorto instantiate objects. (Resolved unit test with php 8.2 WP latest and php 8.2 wp 6.2)