CR-1269998: Fix segfault in gmio_bank_id() for device-based graphs#9799
Merged
Conversation
Add null guard for hw_context before dereferencing it in gmio_bank_id() Signed-off-by: Bikash Singha <bikash.singha@amd.com>
chvamshi-xilinx
approved these changes
May 13, 2026
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
stsoe
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add null guard for hw_context before dereferencing it in gmio_bank_id()
Problem solved by the commit
xrt::graph::gmio_bank_id() causes a segfault when called on a graph created via the deprecated device-based constructor (xrt::graph(device, uuid, name)).
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
CR-1269998 (https://jira.xilinx.com/browse/CR-1269998).
How problem was solved, alternative solutions (if any) and why they were rejected
Added an early if (!hw_ctx) check in graph_impl::gmio_bank_id() before calling hw_ctx.get_xclbin().
Risks (if any) associated the changes in the commit
None.
What has been tested and how, request additional testing if necessary
Tested on Versal board with both hw_context path -- passes as before and device path -- now throws a clear exception instead of segfault.
Documentation impact (if any)
None.