Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
hal.flashdidn't work on RP2350 as it tried to use the second stage bootloader for XIP setup which obviously wasn't available (this is only a RP2040 thing). Conveniently, on RP2350, the bootrom places a copy of the XIP setup function in boot ram that we can use instead.Tested on RP2350 (arm, arm_flashless and riscv). I haven't run any tests on RP2040.
PS: I have reverted some of my changes from #705. The reason for this is that stage2_rom didn't have any guaratee for being half word aligned and jumping to it is therefore unsafe. Aligning it is not that hard (but also not trivial as
@embedFiledoesn't allow you to specify alignment), but I noticed that pico sdk doesn't use the second stage bootloader in flashless images so maybe it is best to do as they do it. I can re-revert this if it is not wanted.PS_2: I might have discovered a bug in pico-sdk here. They set the thumb bit regardless of the architecture. It might not be a bug if on riscv PICO_NO_FLASH is expected to be set but idk.
Fixes #932