[Accton][AS7326-56X] Show MFU ver with onlpdump -x#163
Open
vincentchiang-ec wants to merge 1 commit intoaccton:support_linux_6.1from
Open
[Accton][AS7326-56X] Show MFU ver with onlpdump -x#163vincentchiang-ec wants to merge 1 commit intoaccton:support_linux_6.1from
vincentchiang-ec wants to merge 1 commit intoaccton:support_linux_6.1from
Conversation
1. The last_updated_MFU_version file in ONIE partition is copied to ONL's /var/tmp/ on ONL boot. 2. onlpdump -x reads /var/tmp/last_updated_MFU_version for MFU ver. 3. Move BIOS_VER_PATH from sysi.c to platform_lib.h and add MFU_VER_PATH macro. 4. Use intermediate const char* to avoid passing NULL to aim_fstrdup when BIOS/MFU file is missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onlpdump -xoutput.last_updated_MFU_versionfile in ONIE partition is copied to/var/tmp/on ONL boot.onlpdump -xreads/var/tmp/last_updated_MFU_versionfor MFU version.BIOS_VER_PATHfromsysi.ctoplatform_lib.hand addMFU_VER_PATHmacro.const char*to avoid passing NULL toaim_fstrdupwhen BIOS/MFU file is missing.Same approach as PR #90 (as9716-32d) applied to AS7326-56X. Existing dual-path IDPROM decode loop preserved.
Test plan
onlpdump -xshows BIOS / ONIE / MFU lines./var/tmp/last_updated_MFU_versiondoes not exist, MFU shows empty (no crash).