Add config for bcrypt cost, default to 12 instead of 8.#5084
Open
AndrolGenhald wants to merge 1 commit intoadvplyr:masterfrom
Open
Add config for bcrypt cost, default to 12 instead of 8.#5084AndrolGenhald wants to merge 1 commit intoadvplyr:masterfrom
AndrolGenhald wants to merge 1 commit intoadvplyr:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary
Allow configuring bcrypt cost, default to 12 instead of 8.
In-depth Description
The recommended cost for bcrypt these days is usually 12, with 10 being the recommendation from over a decade ago. This PR adds an environment variable
BCRYPT_COSTto configure the bcrypt cost, with a minimum of 8.I was unable to find any source for the documentation here, so that will need to be updated separately. I recommend updating it with:
BCRYPT_COST(default:12)How have you tested this?
Created several users, logged in after changing bcrypt cost, changed passwords after changing bcrypt cost again.