Add progress stall for ffmpeg podcast downloads#5112
Open
Vito0912 wants to merge 2 commits intoadvplyr:masterfrom
Open
Add progress stall for ffmpeg podcast downloads#5112Vito0912 wants to merge 2 commits intoadvplyr:masterfrom
Vito0912 wants to merge 2 commits intoadvplyr:masterfrom
Conversation
Contributor
|
I believe this should also fix #4116 |
Contributor
Author
|
I just took a very short look at the linked issue, but I don't think so. This is realted to ffmpeg which should have printed progress logs. I didn't see any in the linked issue. I will add a fix later for that too. |
Contributor
Author
|
Now it should also apply to the downloads mentioned in the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary
See Discord below. Just a quick fix, nothing major
Which issue is fixed?
It should fix: https://discord.com/channels/942908292873723984/954760207131615264/1480565704670314516
fixes #4116
In-depth Description
After Axios receives a chunk, the timeout is ignored. ffmpeg waits forever. So if the stream breaks, it will stall forever. Because
.on('progress')is a constant that should be called at least once a second if active data is being streamed, if there is no progress for 60 seconds, it sees the podcast as stalled.How have you tested this?
No. This is only theoretical. I made sure it will not break downloads (I hope).
Screenshots