Add favorite property to library items#5128
Open
Rapha149 wants to merge 3 commits intoadvplyr:masterfrom
Open
Conversation
Contributor
|
Just an FYI, but web client front-end changes are not actively being merged or reviewed right now because we are in the middle of migrating away from Vue to a new framework. You're welcome to leave this open in the meantime (either as inspiration or if someone else wants to use it in the meantime). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary
This pr adds the ability to mark podcasts (and other library items) as favorite and allows to filter for favorite items in the library page and the latest episodes page.
Which issue is fixed?
#2968 and #4816
In-depth Description
Added features:
In the database I implemented it by adding a new table with the columns libraryItemId and userId.
I added two new strings:
LabelFavorite(en: "Favorite") andLabelOnlyFavorites(en: "Only Favorites"), but I only added them in English and German.I also implemented these changes in the apps: advplyr/audiobookshelf-app#1826
How have you tested this?
I tested the desktop and mobile version:
Screenshots
Desktop
Cover:

Item page:


Filter menu:

Latest page:


Mobile
Cover:

Item page:

Filter menu:

Latest page:
