Apply Version Updates From Current Changes#7
Conversation
📝 WalkthroughWalkthroughRelease preparation for tauri-bundler 2.7.3 and tauri-cli 2.9.3 consolidating changelog entries, bumping versions in manifests and packages, and unconditionally exposing HashAlgorithm::Sha256 in http_utils.rs. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
1 similar comment
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@crates/tauri-bundler/src/utils/http_utils.rs`:
- Around line 50-59: The map closure is discarding the computed mirror URL
(named _alt_url) and always returning the original url with a freshly built
agent lacking proxy/platform certs; update the closure produced by
generate_github_mirror_url_from_template and
generate_github_mirror_url_from_base to capture and return the alt_url (use a
named variable like alt_url instead of _alt_url) and reuse the existing agent
configuration (built via ureq::Agent::config_builder() / BUNDLER_USER_AGENT or
the base agent instance) so that when a mirror is configured the returned tuple
is (agent_with_proxies_and_certs, alt_url.to_owned()) rather than always
returning the original url.
| generate_github_mirror_url_from_template(url) | ||
| .or_else(|| generate_github_mirror_url_from_base(url)) | ||
| .map(|alt_url| { | ||
| .map(|_alt_url| { | ||
| ( | ||
| ureq::Agent::config_builder() | ||
| .user_agent(BUNDLER_USER_AGENT) | ||
| .build() | ||
| .into(), | ||
| alt_url, | ||
| url.to_owned(), | ||
| ) |
There was a problem hiding this comment.
Mirror URL is discarded, making mirror env vars effectively no‑ops.
This drops the alternate URL and uses an agent without proxy/platform certs even when a mirror is configured. Consider preserving the mirror URL and reusing the base agent config.
✅ Proposed fix
- generate_github_mirror_url_from_template(url)
- .or_else(|| generate_github_mirror_url_from_base(url))
- .map(|_alt_url| {
- (
- ureq::Agent::config_builder()
- .user_agent(BUNDLER_USER_AGENT)
- .build()
- .into(),
- url.to_owned(),
- )
- })
+ generate_github_mirror_url_from_template(url)
+ .or_else(|| generate_github_mirror_url_from_base(url))
+ .map(|alt_url| (base_ureq_agent(), alt_url))🤖 Prompt for AI Agents
In `@crates/tauri-bundler/src/utils/http_utils.rs` around lines 50 - 59, The map
closure is discarding the computed mirror URL (named _alt_url) and always
returning the original url with a freshly built agent lacking proxy/platform
certs; update the closure produced by generate_github_mirror_url_from_template
and generate_github_mirror_url_from_base to capture and return the alt_url (use
a named variable like alt_url instead of _alt_url) and reuse the existing agent
configuration (built via ureq::Agent::config_builder() / BUNDLER_USER_AGENT or
the base agent instance) so that when a mirror is configured the returned tuple
is (agent_with_proxies_and_certs, alt_url.to_owned()) rather than always
returning the original url.
1 participant
Benchmark PR from agentic-review-benchmarks#7
Summary by CodeRabbit
New Features
Bug Fixes