Skip to content

no_std + alloc crate#6

Open
algesten wants to merge 3 commits intomainfrom
fix/no-std
Open

no_std + alloc crate#6
algesten wants to merge 3 commits intomainfrom
fix/no-std

Conversation

@algesten
Copy link
Copy Markdown
Owner

No description provided.

@brandonros
Copy link
Copy Markdown

could you give https://github.com/brandonros/ureq_wasm_ui a look and help me track down where the std::io usage is coming from (it's in ureq crate but I'm not sure exactly where)? Even if we stub it out with "panic if wasm32 platform", I could help implement "fetch" from there?

@algesten
Copy link
Copy Markdown
Owner Author

I can have a look tomorrow!

This PR fixes only ureq-proto, which is underpinning ureq. So there is still work I need to do in ureq itself. Is this test checking ureq-proto or ureq?

Comment thread src/client/amended.rs
use alloc::string::ToString;
use core::mem;

use http::{HeaderMap, HeaderName, HeaderValue, Method, Request, Uri, Version};
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this using the http crate from hyper? would you want to try from this branch? hyperium/http#732 otherwise i'm confused how no_std is pulling in a std crate?

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be where it breaks down. The http crate working in webasm is central to this effort.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hyperium/http#749 seems pretty good... are we able to build off of that?

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! We should be able to. Let's hope they merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants