feat(autocapture): add hierarchy CSS class capture option#1765
Draft
Dogfalo wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
captureCssClasses?: booleanto element interaction options, defaulting to current class-capture behavior.classesonly from[Amplitude] Element HierarchywhencaptureCssClassesisfalse.[Amplitude] Element Class, element path generation, selector matching, and Visual Labeling selector behavior.Validation
pnpm --filter @amplitude/analytics-core buildpnpm jest --coverage=false --runTestsByPath test/hierarchy.test.ts test/data-extractor.test.tsfrompackages/plugin-autocapture-browserpnpm jest --coverage=false --runTestsByPath test/default-tracking.test.tsfrompackages/analytics-browserpnpm exec prettier --check packages/analytics-core/src/types/element-interactions.ts packages/plugin-autocapture-browser/src/hierarchy.ts packages/plugin-autocapture-browser/src/data-extractor.ts packages/plugin-autocapture-browser/test/hierarchy.test.ts packages/plugin-autocapture-browser/test/data-extractor.test.ts packages/analytics-browser/test/default-tracking.test.tsNotes
Package-level typecheck commands were attempted but hit existing unrelated workspace issues around generated/linked package declarations and a pre-existing rootDir import in autocapture tests.