Issue 1144 new continuous integration#1260
Conversation
f448f7b to
47193d2
Compare
28ff8d0 to
80de3ba
Compare
80de3ba to
5fd5788
Compare
|
It turns out that getting working MPI and compilers with Homebrew and MacPorts isn't easy. I'd like to get this merged, so I'm going to remove those tests for the time being, so that we at least have per-code tests on Ubuntu and macOS, plus an all-up conda based install and test. |
bd9b25e to
028b929
Compare
|
Okay, I think this is ready to go now. Some of the codes are still failing consistently:
There are also still intermittent timeouts and infrastructure failures, probably because these tests are quite heavy, use MPI, and because this PR runs all of them simultaneously. It's better than it was though due to additional OpenMPI configuration and a switch to MPICH on the macOS side. In normal circumstances code-specific tests will run only for PRs touching that code. This does not include weekly regression tests for macOS with Homebrew and MacPorts, because I had trouble setting those up correctly. You don't just install a compiler or an MPI library with these things and have a working setup. It would help if someone with more mac expertise could do a nice clean setup for that. Let's merge this and continue to set up our custom runner, and also to fix the codes so that everything passes all the time and we don't have broken windows anymore. |
|
Ok for me - not sure how #1248 broke MESA but this is not the right place to discuss about that |
|
Make doesn't work if you use spaces instead of tabs 😄 |
rieder
left a comment
There was a problem hiding this comment.
There seem to be a lot of non-CI changes (e.g. to Makefiles) in this PR, is that by design or by accident?
🤦 |
|
By design, it includes some fixes for issues I ran into:
and somehow a bunch of whitespace fixes in concurrent.py snuck in, sorry. |
|
Looks good |
This adds a whole bunch of CI workflows, one for each code, which run whenever that workflow is changed or when the code is updated. This also contains some technical fixes for various codes, where tests that are too resource intensive for the CI are disabled.
Some of the codes remain broken and need attention from an expert, but I think it's better to have a CI that tells you that things are in that state, than to not have one at all, so after I do some more cleanup I think we should merge this anyway and then go look for someone who can fix things.
Addresses #1144