test(vite-plugin-nitro): cover http2 pseudo-headers#2233
Merged
brandonroberts merged 7 commits intoanalogjs:alphafrom Apr 13, 2026
Merged
test(vite-plugin-nitro): cover http2 pseudo-headers#2233brandonroberts merged 7 commits intoanalogjs:alphafrom
brandonroberts merged 7 commits intoanalogjs:alphafrom
Conversation
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedToo many files! This PR contains 221 files, which is 71 over the limit of 150. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (11)
📒 Files selected for processing (221)
You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughA new Vitest specification has been added for the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
the
scope:vite-plugin-nitro
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ckage-native resolution (analogjs#2279)
github-actions
Bot
added
scope:astro-angular
…http2-pseudo-headers
github-actions
Bot
removed
scope:astro-angular
github-actions
Bot
removed
scope:nx-plugin
Contributor
Author
|
@brandonroberts ready to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Closes #2177
Affected scope
vite-plugin-nitroRecommended merge strategy for maintainer [optional]
Commit preservation note [optional]
What is the new behavior?
Adds a focused regression test around
toWebRequest()to verify that HTTP/2 pseudo-headers are ignored when Analog bridges a Node request into WebHeaders.The implementation already filters pseudo-header keys that start with
:, and this PR turns that existing behavior into an explicit regression guard so the issue can be closed with test coverage.Test plan
nx format:checkpnpm buildpnpm testManual verification:
pnpm nx test vite-plugin-nitro --runTestsByPath packages/vite-plugin-nitro/src/lib/utils/node-web-bridge.spec.tsDoes this PR introduce a breaking change?
Other information
This is a verify-close PR for an issue that already appears fixed in the current implementation. The change is test-only.
[optional] What gif best describes this PR or how it makes you feel?