refactor(tool): convert webfetch tool internals to Effect#21809
Draft
kitlangton wants to merge 1 commit intodevfrom
Draft
refactor(tool): convert webfetch tool internals to Effect#21809kitlangton wants to merge 1 commit intodevfrom
kitlangton wants to merge 1 commit intodevfrom
Conversation
kitlangton
force-pushed
the
kit/tool-effect-webfetch
branch
2 times, most recently
from
4e216ce to
491964e
Compare
Replace raw fetch with Effect HttpClient service. Remove manual AbortController/signal/clearTimeout plumbing — fiber interruption and Effect.timeout handle cancellation natively. Update registry to yield WebFetchTool and provide FetchHttpClient.layer. Fix tests to provide FetchHttpClient.layer where needed.
kitlangton
force-pushed
the
kit/tool-effect-webfetch
branch
from
491964e to
91a3eef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mechanical conversion of the
webfetchtool's execute method from async/await toEffect.gen+Effect.promise, withEffect.runPromiseat the boundary. No behavioral change — precursor to eventually making tool execute return Effect natively.