Cache dataTasks() result in NodeFileScanTask to avoid repeated list creation#4146
Merged
czy006 merged 3 commits intoapache:masterfrom Apr 15, 2026
Merged
Cache dataTasks() result in NodeFileScanTask to avoid repeated list creation#4146czy006 merged 3 commits intoapache:masterfrom
czy006 merged 3 commits intoapache:masterfrom
Conversation
…list creation dataTasks() was creating a new List via Stream.concat().collect(toList()) on every call. Since the result is immutable after construction (or after addFile() calls complete), cache it lazily and invalidate the cache in addFile() when baseTasks or insertTasks are mutated. Signed-off-by: Jiwon Park <jpark92@outlook.kr>
Signed-off-by: Jiwon Park <jpark92@outlook.kr>
Signed-off-by: Jiwon Park <jpark92@outlook.kr>
j1wonpark
force-pushed
the
fix/cache-data-tasks
branch
from
70582c3 to
bcd212c
Compare
czy006
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
NodeFileScanTask.dataTasks()creates a newArrayListviaStream.concat().collect(toList())on every call, even though the contents are immutable after construction. Since the result doesn't change between calls, caching avoids redundant list creation.Brief change log
NodeFileScanTask.dataTasks()with acachedDataTasksfieldCollections.unmodifiableList()to prevent external mutationcachedDataTasks = null) inaddFile()to ensure correctness when tasks are added after constructionHow was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation