Skip to content

Removed outdated Microsoft OpenJDK vendor hardcoding which causes errors#230

Open
jmjaffe37 wants to merge 1 commit intoapache:masterfrom
jmjaffe37:microsoft/remove_hardcoding
Open

Removed outdated Microsoft OpenJDK vendor hardcoding which causes errors#230
jmjaffe37 wants to merge 1 commit intoapache:masterfrom
jmjaffe37:microsoft/remove_hardcoding

Conversation

@jmjaffe37
Copy link
Copy Markdown

This hardcoding has been outdated for a few years. Since then, quite a few GitHub issues have appeared where problems are experienced as a result of this hardcoding. Example: microsoft/openjdk#339

Note, the only changes here are:

  • I removed the if-statement which adds hardcoding for the Microsoft OpenJDK vendor
  • I restored the spacing of everything in the else-statement to be in line with the function

@jmjaffe37 jmjaffe37 changed the title Removed outdated Microsoft vendor hardcoding which can cause errors Removed outdated Microsoft OpenJDK vendor hardcoding which can cause errors Apr 10, 2026
@jmjaffe37 jmjaffe37 changed the title Removed outdated Microsoft OpenJDK vendor hardcoding which can cause errors Removed outdated Microsoft OpenJDK vendor hardcoding which causes errors Apr 10, 2026
@jaikiran
Copy link
Copy Markdown
Member

This change looks OK to me. It looks like this original code was added back in 2001. I'll wait to hear from Stefan or someone familiar with this code/history before merging it.

@jaikiran
Copy link
Copy Markdown
Member

Hello @jmjaffe37,

This hardcoding has been outdated for a few years.

Would you happen to know if there could be users of some old versions of Microsoft released JDKs which may have this Packages directory? Are there any such versions of the JDKs still around? If yes, then a slightly different fix which involves a check for the presence of the File(JavaEnvUtils.getJavaHome() + File.separator + "Packages") directory before adding it, might be necessary here.

@bodewig
Copy link
Copy Markdown
Member

bodewig commented Apr 11, 2026

I'd be fine with using the patch as is. We could as well set erroronmissingdir to false in msZipFiles to avoid the error linked by @jmjaffe37 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants