Skip to content

[fix](decimalv2) fix wrong result of decimalv2 avg#62346

Merged
yiguolei merged 1 commit intoapache:masterfrom
jacktengg:260410-fix-decimalv2-avg
Apr 13, 2026
Merged

[fix](decimalv2) fix wrong result of decimalv2 avg#62346
yiguolei merged 1 commit intoapache:masterfrom
jacktengg:260410-fix-decimalv2-avg

Conversation

@jacktengg
Copy link
Copy Markdown
Contributor

@jacktengg jacktengg commented Apr 10, 2026

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #58666

Problem Summary:

When getting avg(decimalv2) result, DecimalV2 has fixed internal scale=9, its arithmetic operators already handle scale correctly, so no external multiplier is needed.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@jacktengg
Copy link
Copy Markdown
Contributor Author

run buildall

@Thearas
Copy link
Copy Markdown
Contributor

Thearas commented Apr 10, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen
Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.97% (26770/37198)
Line Coverage 54.95% (283691/516243)
Region Coverage 51.97% (234870/451925)
Branch Coverage 53.43% (101578/190105)

@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yiguolei
Copy link
Copy Markdown
Contributor

skip check_coverage

@yiguolei yiguolei merged commit fcb72f5 into apache:master Apr 13, 2026
32 of 34 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 13, 2026
### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #58666

Problem Summary:

When getting avg(decimalv2) result, DecimalV2 has fixed internal
scale=9, its arithmetic operators already handle scale correctly, so no
external multiplier is needed.


### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
yiguolei pushed a commit that referenced this pull request Apr 13, 2026
…#62413)

Cherry-picked from #62346

Co-authored-by: TengJianPing <tengjianping@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.1.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants