Add missing Javadoc for ConnectionConfig#820
Open
garydgregory wants to merge 2 commits intoapache:masterfrom
Open
Add missing Javadoc for ConnectionConfig#820garydgregory wants to merge 2 commits intoapache:masterfrom
garydgregory wants to merge 2 commits intoapache:masterfrom
Conversation
ok2c
requested changes
Apr 11, 2026
| * A timeout value of zero is interpreted as an infinite timeout. | ||
| * </p> | ||
| * | ||
| * @return the timeout until a new connection is fully established, defaults to 3 minutes. |
Member
There was a problem hiding this comment.
@garydgregory Can we re-phrase this statement a little? Technically the connection timeout is a timeout until the target endpoint acknowledgement it accepts the connection request, not until the new connection is fully established. For instance an HTTPS connection cannot be considered fully established until the TLS handshake has been successfully completed.
Very nice otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing Javadoc for
ConnectionConfig.