Skip to content

CI: Use specific patch versions in workflow action comments#2412

Merged
CTTY merged 1 commit into
apache:mainfrom
kevinjqliu:kevinjqliu/fix-gh-workflow-pin
May 6, 2026
Merged

CI: Use specific patch versions in workflow action comments#2412
CTTY merged 1 commit into
apache:mainfrom
kevinjqliu:kevinjqliu/fix-gh-workflow-pin

Conversation

@kevinjqliu
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

  • Closes #.

What changes are included in this PR?

Similar to apache/iceberg#16229

The workflow files use SHA-pinned actions (immutable), but the human-readable comments referenced only major versions (e.g., # v6, # v5).
When maintainers move these mutable tags to a new commit, zizmor fails in CI because the SHA no longer matches the stated tag.

Are these changes tested?

Copy link
Copy Markdown
Collaborator

@CTTY CTTY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CTTY CTTY merged commit 03be59e into apache:main May 6, 2026
23 checks passed
@kevinjqliu kevinjqliu deleted the kevinjqliu/fix-gh-workflow-pin branch May 6, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants