fix(reader): allow predicates on nested-leaf columns#2433
Open
vvarma wants to merge 2 commits into
Open
Conversation
Predicates that reference a primitive leaf inside a struct were rejected by PredicateConverter::bound_reference because the parquet column root for a nested leaf is the surrounding group. The downstream get_row_filter -> ArrowPredicateFn pipeline already projects each requested leaf via ProjectionMask::leaves; the leaf is available through the projected RecordBatch, just nested under its parent struct. Two changes: 1. Drop the get_column_root(...).is_group() rejection 2. Have bound_reference return the parquet column path (root -> leaf) instead of just the leaf's projected index. project_column now walks that path: top-level columns work as before, nested-leaf paths descend through StructArray children by name. Tests added: 1. test_get_row_filter_accepts_predicate_on_nested_leaf covers row-filter construction for a nested leaf path. 2. test_perform_read_with_nested_leaf_predicate writes a Parquet file with a struct leaf and verifies the full ArrowReader pipeline returns only the row matching nested.value = 20.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Predicates that reference a primitive leaf inside a struct were rejected by PredicateConverter::bound_reference because the parquet column root for a nested leaf is the surrounding group. The downstream get_row_filter -> ArrowPredicateFn pipeline already projects each requested leaf via ProjectionMask::leaves; the leaf is available through the projected RecordBatch, just nested under its parent struct.
Two changes:
Drop the get_column_root(...).is_group() rejection
Have bound_reference return the parquet column path (root -> leaf) instead of just the leaf's projected index. project_column now walks that path: top-level columns work as before, nested-leaf paths descend through StructArray children by name.
Are these changes tested?
Tests added:
test_get_row_filter_accepts_predicate_on_nested_leaf covers row-filter construction for a nested leaf path.
test_perform_read_with_nested_leaf_predicate writes a Parquet file with a struct leaf and verifies the full ArrowReader pipeline returns only the row matching nested.value = 20.