fix(iceberg): Implement JSON serde for Fixed/Binary literals#2436
Open
YuangGao wants to merge 1 commit into
Open
fix(iceberg): Implement JSON serde for Fixed/Binary literals#2436YuangGao wants to merge 1 commit into
YuangGao wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Fixes two bugs in
LiteralJSON serialization forFixed/Binary:try_from_json: replacetodo!()with hex parsing;Fixed(n)validates length, invalid input returnsDataInvalidinstead of panicking.try_into_json: change"{x:x}"to"{x:02x}"so bytes< 0x10keep their leading zero (e.g.[0x00, 0xff, 0x05]now encodes to"00ff05", not"0ff5").The two bugs masked each other — no existing test covered the
Fixed/BinaryJSON path. No new dependencies (usesu8::from_str_radix).Are these changes tested?
Yes, four new unit tests in
crates/iceberg/src/spec/values/tests.rs:test_json_serde_binary—Binaryround-trip with"00ff05"(regression for the zero-padding bug).test_json_serde_fixed—Fixed(4)round-trip.test_try_from_json_fixed_length_mismatch—Fixed(5)rejects 4-byte hex input.test_try_from_json_binary_invalid_hex— non-hex input returnsErr.