Skip to content

API: Remove unnecessary EOFException in FileRange constructor. #15973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huaxingao merged 2 commits into from
May 12, 2026
+5 −16
Merged

API: Remove unnecessary EOFException in FileRange constructor. #15973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fc8d6f
API: Remove unnecessary EOFException FileRange constructor.
mukund-thakur Apr 14, 2026
f3290ce
Review comment
mukund-thakur May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions api/src/main/java/org/apache/iceberg/io/FileRange.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
*/
package org.apache.iceberg.io;

import java.io.EOFException;
import java.nio.ByteBuffer;
import java.util.concurrent.CompletableFuture;
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
Expand All @@ -28,8 +27,7 @@ public class FileRange {
private final long offset;
private final int length;

public FileRange(CompletableFuture<ByteBuffer> byteBuffer, long offset, int length)
throws EOFException {
public FileRange(CompletableFuture<ByteBuffer> byteBuffer, long offset, int length) {
Comment thread
mukund-thakur marked this conversation as resolved.
Preconditions.checkNotNull(byteBuffer, "byteBuffer can't be null");
Preconditions.checkArgument(
length() >= 0, "Invalid length: %s in range (must be >= 0)", length);
Comment thread
mukund-thakur marked this conversation as resolved.
Expand Down
17 changes: 4 additions & 13 deletions parquet/src/main/java/org/apache/iceberg/parquet/ParquetIO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
*/
package org.apache.iceberg.parquet;

import java.io.EOFException;
import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;
Expand Down Expand Up @@ -187,18 +186,10 @@ private static List<FileRange> convertRanges(List<ParquetFileRange> ranges) {
parquetFileRange -> {
CompletableFuture<ByteBuffer> future = new CompletableFuture<>();
parquetFileRange.setDataReadFuture(future);
try {
return new FileRange(
parquetFileRange.getDataReadFuture(),
parquetFileRange.getOffset(),
parquetFileRange.getLength());
} catch (EOFException e) {
throw new RuntimeIOException(
e,
"Failed to create range file for offset: %s and length: %s",
parquetFileRange.getOffset(),
parquetFileRange.getLength());
}
return new FileRange(
parquetFileRange.getDataReadFuture(),
Comment thread
mukund-thakur marked this conversation as resolved.
parquetFileRange.getOffset(),
parquetFileRange.getLength());
})
.collect(Collectors.toList());
}
Expand Down