Skip to content

feat(push-api): implement push API with authentication and validation logic#8879

Merged
Startrekzky merged 1 commit into
mainfrom
kw-fix-push-api
May 17, 2026
Merged

feat(push-api): implement push API with authentication and validation logic#8879
Startrekzky merged 1 commit into
mainfrom
kw-fix-push-api

Conversation

@klesh
Copy link
Copy Markdown
Contributor

@klesh klesh commented May 16, 2026

Summary

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

  • default-denies the push API unless PUSH_API_ALLOWED_TABLES is explicitly configured
  • blocks writes to internal _devlake_* tables even if they are mistakenly added to the allowlist
  • requires a Bearer API key on /push/* regardless of AUTH_ENABLED, and adds focused middleware and validation tests

Does this close any open issues?

Closes N/A

Screenshots

N/A

Other Information

  • updated env.example and backend/server/api/push/README.md to reflect the secure push API defaults
  • added coverage in backend/server/api/middlewares_test.go and backend/server/services/pushapiaccess/access_test.go

@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 16, 2026
@klesh klesh added the pr-type/bug-fix This PR fixes a bug label May 16, 2026
@dosubot dosubot Bot added component/framework This issue or PR relates to the framework pr-type/feature-development This PR is to develop a new feature labels May 16, 2026
Copy link
Copy Markdown
Contributor

@Startrekzky Startrekzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Startrekzky Startrekzky merged commit c057341 into main May 17, 2026
14 checks passed
@Startrekzky Startrekzky deleted the kw-fix-push-api branch May 17, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/framework This issue or PR relates to the framework pr-type/bug-fix This PR fixes a bug pr-type/feature-development This PR is to develop a new feature size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants