[BUILD] Use git-commit-id-maven-plugin in server/apps only#2050
Closed
chibenwa wants to merge 1 commit intoapache:masterfrom
Closed
[BUILD] Use git-commit-id-maven-plugin in server/apps only#2050chibenwa wants to merge 1 commit intoapache:masterfrom
chibenwa wants to merge 1 commit intoapache:masterfrom
Conversation
vttranlina
approved these changes
Feb 26, 2024
Contributor
|
Not convinced it will solve our problem down the line, but can try |
quantranhong1999
approved these changes
Feb 26, 2024
Contributor
|
Or not... I just tested it locally with TMail. The problem is still here when you try to build, just been moved: |
Contributor
Author
Both are not mutually exclusive, correct? |
Contributor
I mean you can move the plugin to server/apps sure, but upgrading it to the latests version is still blocking our own build as a result. |
Contributor
Author
|
So we can still merge this... We do not have a command line option to diable that plugin in tmail build? |
Contributor
|
Contributor
|
It's should be possible to completely disable the plugin by command line
parameter. I'll try to look it up but as I said limited connectivity
Ideally the plugin should be associated to a profile to be used only for ci
and release of James.
I am hesitant about not including the version in every artifact. For people
pulling snapshots it felt like a useful feature
|
Contributor
Author
|
You convinced me @jeantil |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.