Skip to content

[BUILD] Use git-commit-id-maven-plugin in server/apps only#2050

Closed
chibenwa wants to merge 1 commit intoapache:masterfrom
chibenwa:git-commit-id
Closed

[BUILD] Use git-commit-id-maven-plugin in server/apps only#2050
chibenwa wants to merge 1 commit intoapache:masterfrom
chibenwa:git-commit-id

Conversation

@chibenwa
Copy link
Copy Markdown
Contributor

No description provided.

@chibenwa chibenwa self-assigned this Feb 26, 2024
@Arsnael
Copy link
Copy Markdown
Contributor

Arsnael commented Feb 26, 2024

Not convinced it will solve our problem down the line, but can try

@Arsnael
Copy link
Copy Markdown
Contributor

Arsnael commented Feb 26, 2024

Or not... I just tested it locally with TMail.

The problem is still here when you try to build, just been moved:

[ERROR] Failed to execute goal io.github.git-commit-id:git-commit-id-maven-plugin:7.0.0:revision (get-the-git-infos) on project james-server-cli: Git command exited with invalid status [128]: directory: `/home/rene/Dev/github/tmail-backend/.git/modules`, command: `git describe --always --dirty=-dirty --match=* --abbrev=7`, stdout: ``, stderr: `fatal: this operation must be run in a work tree` -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :james-server-cli

@chibenwa
Copy link
Copy Markdown
Contributor Author

Not convinced it will solve our problem down the line, but can try

Both are not mutually exclusive, correct?

@Arsnael
Copy link
Copy Markdown
Contributor

Arsnael commented Feb 27, 2024

Both are not mutually exclusive, correct?

I mean you can move the plugin to server/apps sure, but upgrading it to the latests version is still blocking our own build as a result.

@chibenwa
Copy link
Copy Markdown
Contributor Author

So we can still merge this...

We do not have a command line option to diable that plugin in tmail build?

@Arsnael
Copy link
Copy Markdown
Contributor

Arsnael commented Feb 27, 2024

We do not have a command line option to diable that plugin in tmail build?

#2049 (comment)

@jeantil
Copy link
Copy Markdown
Contributor

jeantil commented Feb 27, 2024 via email

@chibenwa
Copy link
Copy Markdown
Contributor Author

You convinced me @jeantil

@chibenwa chibenwa closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants