Enable loading of bundles importing java.-packages and update Bouncy Castle to fix jgit signing#9329
Conversation
b73161f to
8d46f6c
Compare
|
refreshed #8892 and temporarily added this PR to it to test everything together with jgit 7.4. edit: smoke test worked, modules loaded + tested basic git workflow |
a254fe1 to
59c58a0
Compare
mbien
left a comment
There was a problem hiding this comment.
changes look good. Checked the dependency tree for the new versions and nothing changed there.
osgi.nb10 probably needs its final hosting location still
Newer bouncy castle JARs declare an import of the java.io package. This is rejected by the manifest verification in the equinox version NetBeans uses wrapped into Netbinox. This change deactivates the check in equinox that rejects that entry. Additionally the instructions for building the patched equinox version were updated. Closes: apache#8894
59c58a0 to
86d59af
Compare
Valid point - I wanted to wait with moving to final hosting until this got some opinion apart from mine. Uploaded the artifact to osuosl and updated the corresponding commit. |
|
@matthiasblaesing why does netbeans contain two different OSGI providers? From historical point of view I understood but is there any reason to have them both now? |
|
Yes, while I have no issue with moving a quick fix for NB30, this got merged quite quickly, and there are two open questions here for me. Firstly, are we still looking to remove this OSGi provider in the near future, as that was part of the reasoning behind the Mylyn removal? Secondly, why are we still pushing stuff to OSUOSL when we're trying to move away from using it? Is that the only option here? |
|
#9020 (comment)
I think this is the pragmatic option. OSUOSL usage can be still reduced and ultimately removed but this is a slow / parallel process to other maintenance tasks. |
|
Sure, pragmatism is fine, just checking short term fixes and long term plans don't conflict. I also have a slight issue with us using OSUOSL for new patched binaries. This was not what it was intended to be for, which was hosting legacy things. I do understand it might not be feasible to move this elsewhere at this time, or at all? We do need to consider what is still on there that is not easily migrated to somewhere else. |
jgit signing requires bouncy castle libraries with a version higher equal to or higher than 1.79.
Recent versions of bouncy castle declare an import package:
which is rejected by the NetBeans bundled equinox version. The validation provided by this version rejects alls
java.*imports. This PR removes that check and updates bouncy castle to 18.3.Closes: #8894
Closes: #8776