Skip to content

[Docs] Add tvm.s_tir.tensor_intrin API reference and remove empty legacy tvm/tir directory#19386

Merged
MasterJH5574 merged 3 commits intoapache:mainfrom
tlopex:doc200
Apr 11, 2026
Merged

[Docs] Add tvm.s_tir.tensor_intrin API reference and remove empty legacy tvm/tir directory#19386
MasterJH5574 merged 3 commits intoapache:mainfrom
tlopex:doc200

Conversation

@tlopex
Copy link
Copy Markdown
Member

@tlopex tlopex commented Apr 10, 2026

as per title

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces documentation for the tvm.s_tir.tensor_intrin module and updates type hints across the arith package, transitioning from tvm.tir.Var to tvm.tirx.Var. The review feedback highlights a typo in the relax_map documentation within bound.py and a factual error in the neg_inf docstring in int_set.py where it was incorrectly described as representing positive infinity.

Comment thread python/tvm/arith/bound.py
Domain of variables used to help deduction.

relax_map : Map[tvm.tir.Var, IntSet]
relax_map : Map[tvm.tirx.Var, IntSet]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a typo in the description for relax_map on the following line: 'fomain' should be 'domain'. Since this block is being updated, it's a good opportunity to fix it.

Returns
----------
neg_inf : tvm.tir.Var
neg_inf : tvm.tirx.Var
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The docstring for neg_inf incorrectly describes the return value as indicating 'positive infinity' (both in the summary at line 178 and the parameter description at line 183). It should be 'negative infinity'.

@MasterJH5574 MasterJH5574 merged commit b80d23f into apache:main Apr 11, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants