Skip to content

[WICKET-7179] fix broken focus functionality #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reiern70 merged 1 commit into from
May 13, 2026
+4 −2
Merged

[WICKET-7179] fix broken focus functionality #1457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2202,7 +2202,8 @@

var safeFocus = function() {
try {
toFocus.trigger('focus');
// toFocus is not a JQuery object. Thus use focus.
toFocus.focus();
} catch (ignore) {
// WICKET-6209 IE fails if toFocus is disabled
}
Expand Down
3 changes: 2 additions & 1 deletion ...xtensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/trap-focus.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,8 @@
// ... restore old focus
if (oldActive) {
try {
oldActive.trigger('focus');
// oldActive is not a JQuery element. Then use focus
oldActive.focus();
Wicket.Log.debug("trap-focus: restored focus to element ", oldActive);
} catch (error) {
Wicket.Log.error("trap-focus: error restoring focus. Attempted to set focus to element, but got an exception", oldActive, error);
Expand Down