linted

Author: chrisns

src/github.ts

@@ -16,7 +16,7 @@ export function getAuthenticatedOctokit() {
   })
 }
 
-export async function getGithubUsersFromGithub(): Set<string> {
+export async function getGithubUsersFromGithub(): Promise<Set<string>> {
   const members = await octokit.paginate(octokit.orgs.listMembers, {
     org: process.env.GITHUB_ORG,
   })
@@ -57,7 +57,7 @@ export async function addUsersToGitHubOrg(users: Set<string>): Promise<void> {
   }
 }
 
-export async function addUserToGitHubOrg(user: string): Promise<void> {
+export async function addUserToGitHubOrg(user: string): Promise<void | boolean> {
   if (ignoredUsers.includes(user.toLowerCase())) {
     console.log(`Ignoring add for ${user}`)
     return false

src/google.ts

@@ -23,12 +23,10 @@ export async function getAdminService() {
   })
 }
 
-export async function getGithubUsersFromGoogle(): Set<string> {
+export async function getGithubUsersFromGoogle(): Promise<Set<string>> {
   const service = await getAdminService()
 
-  const userList: {
-    data: { users: Array<userResponseEntry> }
-  } = await service.users.list({
+  const userList = await service.users.list({
     customer: 'my_customer',
     maxResults: 250,
     projection: 'custom',
@@ -40,11 +38,8 @@ export async function getGithubUsersFromGoogle(): Set<string> {
   return githubAccounts
 }
 
-interface userResponseEntry {
-  customSchemas: { Accounts: { github: Array<{ value: string }> } }
-}
-
-export function formatUserList(users: Array<userResponseEntry>): Set<string> {
+// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
+export function formatUserList(users): Set<string> {
   return new Set(
     users
       .map((user) => user?.customSchemas?.Accounts?.github.map((account) => account.value.toLowerCase()))