Skip to content

fix(shellcheck): add deps as source inputs#843

Open
yaroslavvoloshchuk-codaio wants to merge 1 commit into
aspect-build:mainfrom
yaroslavvoloshchuk-codaio:yaroslavvoloshchuk/shellcheck-deps-extra-sources
Open

fix(shellcheck): add deps as source inputs#843
yaroslavvoloshchuk-codaio wants to merge 1 commit into
aspect-build:mainfrom
yaroslavvoloshchuk-codaio:yaroslavvoloshchuk/shellcheck-deps-extra-sources

Conversation

@yaroslavvoloshchuk-codaio
Copy link
Copy Markdown

Summary

  • add deps files as ShellCheck action inputs so sourced sh_library files are available in the sandbox
  • keep the ShellCheck command line limited to the target's direct srcs, so deps are extra source inputs rather than double-linted arguments
  • add a shell example regression that proves a target can source a dep cleanly while the dep is still linted on its own target

Testing

  • cd examples/shell && USE_BAZEL_VERSION=8.x bazel test //test:shellcheck_sourced_main //test:sourced_main_machine_output_empty_test
  • cd examples/shell && USE_BAZEL_VERSION=8.x bazel test //test:shellcheck_sourced_dep //test:sourced_dep_machine_output_test //test:sourced_dep_machine_output_test.uri
  • cd examples/shell && USE_BAZEL_VERSION=8.x bazel test //test:all
  • cd examples/shell && USE_BAZEL_VERSION=8.x bazel build --config=lint --output_groups=rules_lint_human //...
  • cd examples/shell && USE_BAZEL_VERSION=8.x bazel build --config=lint --output_groups=rules_lint_patch --@aspect_rules_lint//lint:fix //...

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 24, 2026

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@aspect-workflows
Copy link
Copy Markdown

aspect-workflows Bot commented Apr 24, 2026

Bazel 7 (Test)

All tests were cache hits

6 tests (100.0%) were fully cached saving 1s.


Bazel 8 (Test)

All tests were cache hits

6 tests (100.0%) were fully cached saving 1s.


Bazel 9 (Test)

All tests were cache hits

6 tests (100.0%) were fully cached saving 1s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants