lint

austenstone · austenstone · commit f674eb30ffe4 · 2025-05-22T09:55:58.000-04:00
diff --git a/backend/package.json b/backend/package.json
@@ -5,10 +5,10 @@
   "description": "Demonstrate the value of GitHub",
   "main": "src/index.ts",
   "scripts": {
-    "start": "node -e \"process.env.NODE_HEAP_SIZE = process.env.NODE_HEAP_SIZE || '4096'; console.log('Using memory limit: ' + process.env.NODE_HEAP_SIZE + 'MB'); process.exit(0)\" && NODE_OPTIONS=\"--max-old-space-size=${NODE_HEAP_SIZE:-6120}\" node --enable-source-maps dist/index.js | bunyan -o short -l info",
+    "start": "node --enable-source-maps dist/index.js | bunyan -o short -l info",
     "test": "vitest",
     "build": "tsc",
-    "dev": "NODE_OPTIONS='--max-old-space-size=4096' tsx watch src/index.ts | bunyan -o short -l info",
+    "dev": "tsx watch src/index.ts | bunyan -o short -l info",
     "lint": "eslint src/**/*.ts",
     "compose:start": "docker-compose -f ../compose.yml up -d",
     "db:start": "docker-compose -f ../compose.yml up -d mongo",
diff --git a/backend/src/services/status.service.ts b/backend/src/services/status.service.ts
@@ -24,9 +24,8 @@ export interface StatusType {
 }
 
 class StatusService {
-  constructor() {
-    
-  }
+  
+  constructor() { }
 
   async getStatus(req?: Request): Promise<StatusType> {
     const status = {} as StatusType;
diff --git a/frontend/src/app/app.module.ts b/frontend/src/app/app.module.ts
@@ -1,7 +1,7 @@
 import { NgModule } from '@angular/core';
 import { ReactiveFormsModule } from '@angular/forms';
 import { MaterialModule } from './material.module';
-import { RouterLink, RouterModule, RouterOutlet, Routes } from '@angular/router';
+import { RouterLink, RouterModule, RouterOutlet } from '@angular/router';
 import { CommonModule } from '@angular/common';
 import { TableComponent } from './shared/table/table.component';
 
diff --git a/frontend/src/app/error/error.component.ts b/frontend/src/app/error/error.component.ts
@@ -22,11 +22,11 @@ export class ErrorComponent {
     private router: Router
   ) {
     const navigation = this.router.getCurrentNavigation();
-    const state = navigation?.extras?.state as { error: any };
+    const state = navigation?.extras?.state;
 
     if (state) {
-      if (state.error) {
-        this.error = state.error || JSON.stringify(state.error);
+      if (state['error']) {
+        this.error = state['error'] || JSON.stringify(state['error']);
       } else {
         this.error.message = 'An unknown error occurred';
       }
diff --git a/frontend/src/app/guards/setup.guard.ts b/frontend/src/app/guards/setup.guard.ts
@@ -1,4 +1,4 @@
-import { Injectable, isDevMode } from '@angular/core';
+import { Injectable } from '@angular/core';
 import { CanActivate, GuardResult, MaybeAsync, Router } from '@angular/router';
 import { of } from 'rxjs';
 import { catchError, map } from 'rxjs/operators';
diff --git a/frontend/src/app/main/copilot/copilot-dashboard/dashboard-card/dashboard-card-bars/dashboard-card-bars.component.ts b/frontend/src/app/main/copilot/copilot-dashboard/dashboard-card/dashboard-card-bars/dashboard-card-bars.component.ts
@@ -5,7 +5,6 @@ import { MatIconModule } from '@angular/material/icon';
 import { MatProgressBarModule } from '@angular/material/progress-bar';
 import { CopilotMetrics } from '../../../../../services/api/metrics.service.interfaces';
 import { HighchartsService } from '../../../../../services/highcharts.service';
-import { LoadingSpinnerComponent } from '../../../../../shared/loading-spinner/loading-spinner.component';
 
 export interface DashboardCardBarsInput {
   value: number;
@@ -23,8 +22,7 @@ export interface DashboardCardBarsInput {
     MatIconModule,
     CommonModule,
     MatProgressBarModule,
-    MatIconModule,
-    // LoadingSpinnerComponent
+    MatIconModule
   ],
   templateUrl: './dashboard-card-bars.component.html',
   styleUrls: [
diff --git a/frontend/src/app/main/copilot/copilot-dashboard/dashboard-card/dashboard-card-drilldown-bar-chart/dashboard-card-drilldown-bar-chart.component.ts b/frontend/src/app/main/copilot/copilot-dashboard/dashboard-card/dashboard-card-drilldown-bar-chart/dashboard-card-drilldown-bar-chart.component.ts
@@ -7,16 +7,14 @@ import { HighchartsChartModule } from 'highcharts-angular';
 import { CommonModule } from '@angular/common';
 import { HighchartsService } from '../../../../../services/highcharts.service';
 import { CopilotMetrics } from '../../../../../services/api/metrics.service.interfaces';
-import { LoadingSpinnerComponent } from '../../../../../shared/loading-spinner/loading-spinner.component';
 
 @Component({
   selector: 'app-dashboard-card-drilldown-bar-chart',
   standalone: true,
   imports: [
     MatCardModule,
     CommonModule,
-    HighchartsChartModule,
-    // LoadingSpinnerComponent
+    HighchartsChartModule
   ],
   templateUrl: './dashboard-card-drilldown-bar-chart.component.html',
   styleUrls: [
diff --git a/frontend/src/app/main/copilot/copilot-dashboard/dashboard-card/dashboard-card-line-chart/dashboard-card-line-chart.component.ts b/frontend/src/app/main/copilot/copilot-dashboard/dashboard-card/dashboard-card-line-chart/dashboard-card-line-chart.component.ts
@@ -1,4 +1,4 @@
-import { Component, Input } from '@angular/core';
+import { Component, Input, OnChanges } from '@angular/core';
 import { CommonModule } from '@angular/common';
 import { HighchartsChartModule } from 'highcharts-angular';
 import * as Highcharts from 'highcharts';
@@ -12,7 +12,7 @@ import { HighchartsService } from '../../../../../services/highcharts.service';
   templateUrl: './dashboard-card-line-chart.component.html',
   styleUrls: ['./dashboard-card-line-chart.component.scss']
 })
-export class DashboardCardLineChartComponent {
+export class DashboardCardLineChartComponent implements OnChanges {
   @Input() data?: CopilotMetrics[];
 
   Highcharts: typeof Highcharts = Highcharts;
diff --git a/frontend/src/app/main/copilot/copilot-dashboard/dashboard.component.ts b/frontend/src/app/main/copilot/copilot-dashboard/dashboard.component.ts
@@ -1,12 +1,10 @@
 import { ChangeDetectorRef, Component, OnDestroy, OnInit } from '@angular/core';
 import { AppModule } from '../../../app.module';
-import { DashboardCardValueComponent } from './dashboard-card/dashboard-card-value/dashboard-card-value.component';
 import { MetricsService } from '../../../services/api/metrics.service';
 import { CopilotMetrics } from '../../../services/api/metrics.service.interfaces';
-import { ActivityResponse, Seat, SeatService } from '../../../services/api/seat.service';
-import { MembersService } from '../../../services/api/members.service';
+import { ActivityResponse, SeatService } from '../../../services/api/seat.service';
 import { CopilotSurveyService, Survey } from '../../../services/api/copilot-survey.service';
-import { forkJoin, Subject, Subscription, takeUntil } from 'rxjs';
+import { Subject, Subscription, takeUntil } from 'rxjs';
 import { AdoptionChartComponent } from '../copilot-value/adoption-chart/adoption-chart.component';
 import { DailyActivityChartComponent } from '../copilot-value/daily-activity-chart/daily-activity-chart.component';
 import { TimeSavedChartComponent } from '../copilot-value/time-saved-chart/time-saved-chart.component';
@@ -104,7 +102,6 @@ export class CopilotDashboardComponent implements OnInit, OnDestroy {
 
   constructor(
     private metricsService: MetricsService,
-    private membersService: MembersService,
     private seatService: SeatService,
     private surveyService: CopilotSurveyService,
     private installationsService: InstallationsService,
diff --git a/frontend/src/app/main/copilot/copilot-metrics/copilot-metrics.component.ts b/frontend/src/app/main/copilot/copilot-metrics/copilot-metrics.component.ts
@@ -1,4 +1,4 @@
-import { ChangeDetectorRef, Component, OnInit } from '@angular/core';
+import { ChangeDetectorRef, Component, OnDestroy, OnInit } from '@angular/core';
 import { DateRangeSelectComponent } from "../../../shared/date-range-select/date-range-select.component";
 import { MetricsService } from '../../../services/api/metrics.service';
 import { CopilotMetrics } from '../../../services/api/metrics.service.interfaces';
@@ -34,7 +34,7 @@ import { DashboardCardLineChartComponent } from '../copilot-dashboard/dashboard-
     '../copilot-dashboard/dashboard.component.scss'
   ]
 })
-export class CopilotMetricsComponent implements OnInit {
+export class CopilotMetricsComponent implements OnInit, OnDestroy {
   metrics?: CopilotMetrics[];
   metricsTotals?: CopilotMetrics;
   installation?: Installation = undefined;
diff --git a/frontend/src/app/main/copilot/copilot-seats/copilot-seat/copilot-seat.component.ts b/frontend/src/app/main/copilot/copilot-seats/copilot-seat/copilot-seat.component.ts
@@ -21,16 +21,6 @@ dayjs.extend(relativeTime);
 
 type TimeRange = '7days' | '30days' | 'all';
 
-// Define interfaces for the activity data structure
-interface Activity {
-  duration?: number;
-  // Add other activity properties as needed
-}
-
-interface SeatWithActivity extends Seat {
-  activity?: Activity[];
-}
-
 @Component({
   selector: 'app-copilot-seat',
   standalone: true,
@@ -89,8 +79,8 @@ export class CopilotSeatComponent implements OnInit {
   timeSpent?: string;
   selectedTimeRange: TimeRange = '7days';
   loading = false;
-  surveyCount: number = 0;
-  avgTimeSavings: string = 'N/A';
+  surveyCount = 0;
+  avgTimeSavings = 'N/A';
 
   constructor(
     private copilotSeatService: SeatService,
@@ -223,7 +213,7 @@ export class CopilotSeatComponent implements OnInit {
           this.updateFlag = true;
           this.cdr.detectChanges();
         },
-        error: (error: any) => {
+        error: (error) => {
           console.error('Error loading data:', error);
           // Hide loading indicator - SET TO FALSE even if there's an error
           this.loading = false;
diff --git a/frontend/src/app/main/copilot/copilot-seats/copilot-seats.component.ts b/frontend/src/app/main/copilot/copilot-seats/copilot-seats.component.ts
@@ -1,4 +1,4 @@
-import { Component, OnInit, ViewChild } from '@angular/core';
+import { Component, OnInit } from '@angular/core';
 import { ColumnOptions, TableComponent } from '../../../shared/table/table.component';
 import { AllSeats, Seat, SeatService } from '../../../services/api/seat.service';
 import { SortDirection } from '@angular/material/sort';
diff --git a/frontend/src/app/main/copilot/copilot-surveys/github.service.ts b/frontend/src/app/main/copilot/copilot-surveys/github.service.ts
@@ -1,6 +1,5 @@
 import { Injectable } from '@angular/core';
 import { HttpClient } from '@angular/common/http';
-import { Observable } from 'rxjs';
 
 @Injectable({
   providedIn: 'root'
@@ -10,7 +9,7 @@ export class GithubService {
 
   constructor(private http: HttpClient) {}
 
-  getOrgMembers(): Observable<any[]> {
+  getOrgMembers() {
     return this.http.get<any[]>(`${this.apiUrl}/members`);
   }
 }
diff --git a/frontend/src/app/main/copilot/copilot-surveys/new-copilot-survey/new-copilot-survey.component.ts b/frontend/src/app/main/copilot/copilot-surveys/new-copilot-survey/new-copilot-survey.component.ts
@@ -7,7 +7,7 @@ import { CopilotSurveyService, Survey } from '../../../../services/api/copilot-s
 import { ActivatedRoute, Params, Router } from '@angular/router';
 import { MembersService, Member } from '../../../../services/api/members.service';
 import { InstallationsService } from '../../../../services/api/installations.service';
-import { BehaviorSubject, catchError, finalize, map, Observable, of, Subject, startWith, take } from 'rxjs';
+import { BehaviorSubject, catchError, finalize, map, Observable, of, Subject } from 'rxjs';
 import { MatTooltipModule } from '@angular/material/tooltip';
 import { MatIconModule } from '@angular/material/icon'; // Import MatIconModule
 import { MatFormFieldModule } from '@angular/material/form-field'; // Import MatFormFieldModule
@@ -17,7 +17,7 @@ import { MatProgressSpinnerModule } from '@angular/material/progress-spinner'; /
 import { MatRadioModule } from '@angular/material/radio'; // Import MatRadioModule
 import { MatCardModule } from '@angular/material/card'; // Import MatCardModule
 import { MatSliderModule } from '@angular/material/slider'; // Import MatSliderModule
-import { debounceTime, distinctUntilChanged, filter, switchMap, tap } from 'rxjs/operators';
+import { debounceTime, distinctUntilChanged, filter, switchMap } from 'rxjs/operators';
 import { Seat, SeatService } from '../../../../services/api/seat.service';
 import dayjs from "dayjs";
 
@@ -73,13 +73,13 @@ export class NewCopilotSurveyComponent implements OnInit {
   defaultPercentTimeSaved = 25;
   id: number;
   surveys: Survey[] = [];
-  orgFromApp: string = '';
+  orgFromApp = '';
   hasQueryParams = false;
   
   // Add these properties to fix the template error
-  repo: string = '';
-  prNumber: string = '';
-  
+  repo = '';
+  prNumber = '';
+
   // Use a subject to trigger searches
   private searchTerms = new Subject<string>();
   // Use BehaviorSubject for loading state
@@ -173,6 +173,7 @@ export class NewCopilotSurveyComponent implements OnInit {
       // Handle GitHub URL parsing
       if (params['url'] && params['url'].includes('github.com')) {
         const { org, repo, prNumber } = this.parseGitHubPRUrl(params['url']);
+        this.orgFromApp = org;
         if (!params['repo'] && repo) {
           this.surveyForm.get('repo')?.setValue(repo);
           this.repo = repo;  // Immediately set the property for template access
@@ -184,10 +185,13 @@ export class NewCopilotSurveyComponent implements OnInit {
       }
     });
 
-    // Get organization
-    this.installationsService.currentInstallation.subscribe(installation => {
-      this.orgFromApp = installation?.account?.login || '';
-    });
+    if (!this.orgFromApp) {
+      this.installationsService.currentInstallation.subscribe(installation => {
+        this.orgFromApp = installation?.account?.login || '';
+      });
+    } else {
+      // set organization in installationsService
+    }
 
     this.loadHistoricalReasons();
 
@@ -485,7 +489,7 @@ export class NewCopilotSurveyComponent implements OnInit {
           this.copilotActivityHours = 0;
         }
       },
-      error: (error: any) => {  // Add type annotation here
+      error: (error) => {  // Add type annotation here
         console.error('Error fetching user Copilot activity:', error);
         this.hasCopilotActivity = false;
         this.copilotActivityHours = 0;
diff --git a/frontend/src/app/main/copilot/copilot-value-modeling/copilot-value-modeling.component.ts b/frontend/src/app/main/copilot/copilot-value-modeling/copilot-value-modeling.component.ts
@@ -85,18 +85,13 @@ export class CopilotValueModelingComponent implements OnInit {
   ngOnInit() {
     this.installationsService.currentInstallation.pipe(
       takeUntil(this._destroy$.asObservable())
-    ).subscribe(installation => {
+    ).subscribe(() => { // subscribe to installation to have installation specific targets
       try {
-        //print targets to console after getting them
-        //console.log('Current installation:', installation);
-        // Fetch targets from the service
-        // and assign them to the data sources  
         this.targetsService.getTargets().subscribe(targets => {
           this.orgDataSource = this.transformTargets(targets.org);
           this.userDataSource = this.transformTargets(targets.user);
           this.impactDataSource = this.transformTargets(targets.impact);
         });
-        //print targets to console
         console.log('Targets:', this.orgDataSource, this.userDataSource, this.impactDataSource);
       } catch (error) {
         console.error('Error during initialization:', error);
diff --git a/frontend/src/app/main/copilot/copilot-value/adoption-chart/adoption-chart.component.ts b/frontend/src/app/main/copilot/copilot-value/adoption-chart/adoption-chart.component.ts
@@ -24,7 +24,7 @@ export class AdoptionChartComponent implements OnInit, OnChanges {
   totalUsers = 500;
   @Input() data?: ActivityResponse;
   @Input() targets?: Targets;
-  @Input() yMax: number = 1111;
+  @Input() yMax = 1111;
   @Input() chartOptions?: Highcharts.Options;
   _chartOptions: Highcharts.Options = {
     yAxis: {
@@ -114,7 +114,7 @@ export class AdoptionChartComponent implements OnInit, OnChanges {
       }
       this.updateFlag = true;
       setTimeout(() => {
-        (this.chart?.yAxis[0] as any).plotLinesAndBands[0].render();
+        this.chart?.yAxis[0].update({});
       }, 2000)
     }
   }
diff --git a/frontend/src/app/main/copilot/copilot-value/value.component.ts b/frontend/src/app/main/copilot/copilot-value/value.component.ts
@@ -1,4 +1,4 @@
-import { ChangeDetectorRef, Component, OnInit } from '@angular/core';
+import { ChangeDetectorRef, Component, OnDestroy, OnInit } from '@angular/core';
 import { AppModule } from '../../../app.module';
 import { AdoptionChartComponent } from "./adoption-chart/adoption-chart.component";
 import { ActivityResponse, SeatService } from '../../../services/api/seat.service';
@@ -32,7 +32,7 @@ HC_full_screen(Highcharts);
     // '../copilot-dashboard/dashboard.component.scss'
   ]
 })
-export class CopilotValueComponent implements OnInit {
+export class CopilotValueComponent implements OnInit, OnDestroy {
   activityData?: ActivityResponse;
   metricsData?: CopilotMetrics[];
   targetsData?: Targets;
diff --git a/frontend/src/app/services/api/copilot-survey.service.ts b/frontend/src/app/services/api/copilot-survey.service.ts
@@ -1,4 +1,4 @@
-import { HttpClient, HttpParams } from '@angular/common/http';
+import { HttpClient } from '@angular/common/http';
 import { Injectable } from '@angular/core';
 import { serverUrl } from '../server.service';
 
diff --git a/frontend/src/app/services/api/members.service.ts b/frontend/src/app/services/api/members.service.ts
@@ -2,7 +2,7 @@ import { Injectable } from '@angular/core';
 import { serverUrl } from '../server.service';
 import { HttpClient } from '@angular/common/http';
 import { Endpoints } from '@octokit/types';
-import { catchError, map, Observable, tap } from 'rxjs';
+import { catchError, Observable, tap } from 'rxjs';
 import { throwError } from 'rxjs';
 
 export interface Member {
@@ -45,10 +45,10 @@ export class MembersService {
     });
   }
 
-  getMemberByLogin(login: string, exact: boolean = true) {
+  getMemberByLogin(login: string, exact = true) {
     return this.http.get<Endpoints["GET /users/{username}"]["response"]["data"]>(
       `${this.apiUrl}/${login}`,
-      { params: { exact: String(exact) } }
+      { params: { exact: String(exact) } } // make this boolean not string.
     ).pipe(
       catchError(error => {
         return throwError(() => error);
diff --git a/frontend/src/app/services/highcharts.service.ts b/frontend/src/app/services/highcharts.service.ts
@@ -587,7 +587,7 @@ export class HighchartsService {
       data: [] as CustomHighchartsPointOptions[]
     };
 
-    Object.entries(activity).forEach(([date, dateData]) => {
+    Object.entries(activity).forEach(([date]) => {
       // Skip if totalActive is undefined or 0 or there is a data quality issue making daily suggestions per average user > 250
       const currentMetrics = metrics.find(m => m.date.startsWith(date.slice(0, 10)));
       if (!currentMetrics || (currentMetrics.copilot_ide_code_completions?.total_engaged_users ?? 0) < 1 || ((currentMetrics.copilot_ide_code_completions?.total_code_suggestions ?? 0) / (currentMetrics.copilot_ide_code_completions?.total_engaged_users ?? 1)) > 250) return;
diff --git a/frontend/src/app/shared/directives/thousand-separator.directive.ts b/frontend/src/app/shared/directives/thousand-separator.directive.ts

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { Injectable, isDevMode } from '@angular/core';`
	`1`	`+import { Injectable } from '@angular/core';`
`2`	`2`	`import { CanActivate, GuardResult, MaybeAsync, Router } from '@angular/router';`
`3`	`3`	`import { of } from 'rxjs';`
`4`	`4`	`import { catchError, map } from 'rxjs/operators';`