Remove AWS Batch scheduler and Amazon Linux 2 OS support and support Python 3.13#7394
Open
hanwen-cluster wants to merge 5 commits into
Open
Remove AWS Batch scheduler and Amazon Linux 2 OS support and support Python 3.13#7394hanwen-cluster wants to merge 5 commits into
hanwen-cluster wants to merge 5 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hanwen-cluster
force-pushed
the
developmaydeprecation
branch
9 times, most recently
from
ea9ebb8 to
2a71b0e
Compare
Contributor
Author
|
Secrutiy Exclusions Checker is ignored because the file change is only a whitespace change. |
hanwen-cluster
added
the
skip-security-exclusions-check
Contributor
Author
|
Code scanning results failure is long standing. We will address it separately |
hanwen-cluster
force-pushed
the
developmaydeprecation
branch
from
db1b29f to
5f78294
Compare
hanwen-cluster
changed the title
hehe7318
reviewed
May 18, 2026
hehe7318
requested changes
May 18, 2026
| if cluster.stack.scheduler == "awsbatch": | ||
| if status == RequestedComputeFleetStatus.ENABLED: | ||
| cluster.start() | ||
| elif status == RequestedComputeFleetStatus.DISABLED: |
Contributor
There was a problem hiding this comment.
[Blocking] Let's remove ENABLED and DISABLED from all files, I found in cli/src/pcluster/api/models/requested_compute_fleet_status.py and compute_fleet_status.py.
| @@ -138,7 +136,7 @@ test-suites: | |||
| dimensions: | |||
| - regions: [{{ p4d_24xlarge_CAPACITY_RESERVATION_2_INSTANCES_2_HOURS_YESPG_alinux2 }}] | |||
Contributor
There was a problem hiding this comment.
[Question] Is the region okay? alinux2 -> alinux2023.
Contributor
Author
There was a problem hiding this comment.
Great discover. FIxed
Contributor
There was a problem hiding this comment.
[Non-blocking] Test name: no_awsbatch. Can we rename?
| _run_and_assert(mocker, capsys, output, error, config, temp_path_for_config) | ||
|
|
||
|
|
||
| def test_subnet_automation_no_awsbatch_no_errors_empty_vpc(mocker, capsys, test_datadir, temp_path_for_config): |
Contributor
There was a problem hiding this comment.
[Non-blocking] no_awsbatch Rename?
Contributor
Author
Because this is a separate task, can I finish it with a separate PR? |
hanwen-cluster
force-pushed
the
developmaydeprecation
branch
from
5f78294 to
70b4023
Compare
Changes - Delete awsbatch-cli/ package, awsbatch_builder.py, awsbatch_validators.py, Batch API client, and all Batch integration tests - Remove Batch from schemas, constants, cluster model, IAM policy templates, and CI workflows - Remove AL2 from supported OS list and image builder configs - Mechanically replace Os: alinux2 → Os: alinux2023 across all test config YAMLs - Delete Batch-only utility scripts (generate-ami-list.py, update_pcluster_configs.py, upload-script.py, bump-awsbatch-cli-version.sh) — these have no Slurm equivalent use Notes for reviewers - pcluster configure wizard removes the scheduler selection prompt entirely since Slurm is now the only option. - conditions gating on scheduler type are simplified; is_awsbatch helper and related conditional logic removed rather than left as dead code.
This commit add `Cache.clear_all()` to conftest of unit test because Python 3.13 reuse caches more actively. Without `Cache.clear_all()`, some tests were failing
DCV test failed on environment where SSH key path is not configured for autouse. Specifying the key path solves the problem
Retrieving AMIs with status pending causes cluster creation failure. This could happen when we are building AMIs and running tests concurrently with the same version of ParallelCluster
In the past, the workflows checked content on full diff (addition and deletion) and limited the maximum file changes to 300. Now the improved workflows check only additions
hanwen-cluster
force-pushed
the
developmaydeprecation
branch
from
70b4023 to
4d3603f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
availablestatus to prevent race conditions during concurrent AMI buildsSee commit descriptions for details.
Tests
References
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.