fix: surface startTransform errors instead of swallowing them#2706
Open
Rajanna-Karthik wants to merge 1 commit intomainfrom
Open
fix: surface startTransform errors instead of swallowing them#2706Rajanna-Karthik wants to merge 1 commit intomainfrom
Rajanna-Karthik wants to merge 1 commit intomainfrom
Conversation
Rajanna-Karthik
force-pushed
the
karsraja/fix-error-swallowing
branch
2 times, most recently
from
e450c06 to
fec5900
Compare
Return error object from catch block in atxNetTransformServer.ts instead of implicitly returning undefined. Add console.log in TEST 2 to log the raw startTransform response for debugging.
Rajanna-Karthik
force-pushed
the
karsraja/fix-error-swallowing
branch
from
fec5900 to
ee876b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ATX Transform commands fail, the LSP server's executeCommand handler catches errors and silently returns undefined. This makes it impossible to diagnose failures from test output or client-side logs — the only visible symptom is expected undefined to exist with no indication of what went wrong.
This caused the LSP integ test alarm (V2135436135) to remain open for 47 days. The actual root cause was a ValidationException: max jobs quota reached, but it took multiple hours of log investigation to discover because the error was swallowed.
Changes
atxNetTransformServer.ts: Return { error: String(e) } from the catch block instead of implicitly returning undefined. Callers that check for specific fields (e.g., TransformationJobId) are unaffected — the field will still be undefined. Verified safe against the toolkit C# AtxStartTransformResponse modelwhich uses [DataMember] deserialization and ignores unknown fields.
atxTransformHandler.ts: Enhanced createJob error logging to include requestId and httpStatusCode from the AWS SDK error metadata. No behavior change — still returns null.atxTransformInteg.test.ts: Added console.log of the raw startTransform response before the assertion, so errors are visible in CodeBuild output.Testing
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.