fix(amazonq): prevent file link click from crashing language server#2718
Open
laileni-aws wants to merge 1 commit intoaws:feature/file-link-not-workingfrom
Open
Conversation
Add error handling to onFileClicked to catch exceptions from showDocument when the target file doesn't exist. Fix resolveAbsolutePath to verify the file exists in the prompts directory before returning the path, preventing incorrect fallback for .md files created by fsWrite. Use description as fullPath fallback in the chat-client file list mapping so fsWrite file links resolve correctly without duplicating path data. Fixes: aws/amazon-q-vscode#59
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/file-link-not-working #2718 +/- ##
=================================================================
- Coverage 60.57% 60.54% -0.04%
=================================================================
Files 279 279
Lines 66275 66284 +9
Branches 4253 4253
=================================================================
- Hits 40149 40131 -18
- Misses 26041 26068 +27
Partials 85 85
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aseemxs
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Clicking a file link in agentic chat for a file created by
fsWritecrashes the language serverand loses all chat context. Two bugs combine to cause this:
#resolveAbsolutePathassumes any.mdfile not found in workspace folders is a user promptfile and returns
~/.aws/amazonq/prompts/<filename>without checking if it exists there.onFileClickedhas no error handling — whenshowDocumentrejects because the file doesn'texist, the unhandled promise rejection crashes the language server process.
The fsWrite file link also never passes
fullPaththrough the click handler data, so even whenthe toolUseLookup fails to match, the fallback path resolution receives only the basename.
Solution
onFileClickedin try/catch so a failedshowDocumentlogs an error instead of crashingthe server
fs.existscheck in#resolveAbsolutePathbefore returning the prompts directory pathdescription(which already contains the full absolute path) asfullPathinthe chat-client file list mapping, reusing existing data instead of adding a redundant field
Testing
tsc --noEmitpasses for bothaws-lsp-codewhispererandchat-clientpackagescontextUtilstests pass.mdfile via fsWrite in agentic chat, click the link — should opencorrectly or log an error gracefully without crashing
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.