fix(simulator): remove double-application of scaleFactor in targetCalls

[meyer9]

Root cause

scaleFactor is applied per-tx inside sendTxs to scale up the operations each transaction performs:

// line 608 — scaleFactor applied inside each tx's operation count
expected := t.payloadParams.Mul(float64(t.numCalls+1) * t.scaleFactor)
blockCounts := expected.Sub(actual).Round()

So each tx already does scaleFactor × payloadParams operations (e.g. with avg_gas_used=35M and GasLimit=200M, scaleFactor≈5.71, each tx does ~280 storage reads instead of 49).

targetCalls was then computed as:

targetCalls := uint64(math.Ceil(float64(t.numCallsPerBlock) * t.scaleFactor))
// = ceil(100 * 5.71) = 572

This multiplies scaleFactor in a second time at the tx-count level. The result: the simulator tries to keep 572 txs in flight per block, but the builder only absorbs ~100 (the actual numCallsPerBlock worth of gas). After 2 blocks, pendingTxs grows past 572 and callsToSend=0 forever — producing empty (deposit-only) blocks for the rest of the run.

Observed: 7,000+ consecutive empty blocks in a 900-block base-mainnet-simulation run (GasLimit=200M, calls_per_block=100, avg_gas_used=35M).

Fix

targetCalls should be numCallsPerBlock — the number of txs to send per block. scaleFactor belongs only inside the per-tx operation calculation.

// Before
targetCalls := uint64(math.Ceil(float64(t.numCallsPerBlock) * t.scaleFactor))

// After
targetCalls := t.numCallsPerBlock

The configForAllBlocks storage pre-allocation at Setup (line 392) correctly uses numCallsPerBlock × numBlocks × scaleFactor × 1.05 — scaleFactor appears once there too, so no change needed.

[cb-heimdall]

🟡 Heimdall Review Status

Requirement	Status	More Info
Reviews	🟡 0/1	Denominator calculation Show calculation 1 if user is bot 0 1 if user is external 0 2 if repo is sensitive 0 From .codeflow.yml 1 Additional review requirements Show calculation Max 0 0 From CODEOWNERS 0 Global minimum 0 Max 1 1 1 if commit is unverified 0 Sum 1

[meyer9]

Replaced by cleaner branch — one commit, one file.