Skip to content

fix(report): handle empty load test block ranges#187

Merged
danyalprout merged 1 commit into
mainfrom
niran/fix-load-test-empty-block-range
May 16, 2026
Merged

fix(report): handle empty load test block ranges#187
danyalprout merged 1 commit into
mainfrom
niran/fix-load-test-empty-block-range

Conversation

@niran
Copy link
Copy Markdown
Contributor

@niran niran commented May 16, 2026

Summary

  • Treat load-test first_block and last_block as optional because failed runs omit them.
  • Render No confirmed transactions when a load-test result has no confirmed block range.

Test plan

  • yarn check
  • yarn test --run
  • yarn build with a local output/.keep placeholder for the existing static-copy target

Render failed load-test runs that have no confirmed blocks instead of assuming first_block and last_block are present in the API response.

Co-authored-by: Codex <noreply@openai.com>
@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented May 16, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@danyalprout danyalprout enabled auto-merge (squash) May 16, 2026 03:23
@danyalprout danyalprout merged commit e071848 into main May 16, 2026
15 checks passed
@danyalprout danyalprout deleted the niran/fix-load-test-empty-block-range branch May 16, 2026 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants