fix(withdrawer): prevent duplicate withdrawal execution and eliminate TransactOpts race condition#77
Open
yasnazariel wants to merge 1 commit into
Open
fix(withdrawer): prevent duplicate withdrawal execution and eliminate TransactOpts race condition#77yasnazariel wants to merge 1 commit into
yasnazariel wants to merge 1 commit into
Conversation
…ng to inconsistent transaction behavior - Duplicate transaction submissions (gas loss, UX degradation) - Race condition leading to incorrect or conflicting transactions - Potential nonce mismanagement in concurrent environments - Increased RPC overhead and reduced reliability While on-chain contracts may prevent double-finalization, the client-side behavior remains unsafe and can lead to operational issues.
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the safety and correctness of the withdrawal flow by addressing two key issues:
Impact:
No breaking changes. Behavior remains consistent for valid flows.