fix: Fix bzlmod repo resolution in oci_pull#891
Conversation
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0cfd139fe
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| load("@aspect_bazel_lib//lib:copy_to_directory.bzl", "copy_to_directory") | ||
| load("@package_metadata//rules:package_metadata.bzl", "package_metadata") | ||
| load("@rules_oci//oci/private:pull.bzl", "copy_to_directory", "package_metadata") |
There was a problem hiding this comment.
Preserve repo-name remapping in generated oci_pull BUILD
The generated BUILD.bazel now hard-codes load("@rules_oci//oci/private:pull.bzl", ...), which breaks consumers that import this module under a different apparent repo name (for example via bazel_dep(..., repo_name = "...") or non-rules_oci WORKSPACE names). Before this change, the generated file only loaded @aspect_bazel_lib/@package_metadata and did not require a @rules_oci alias, so this introduces a new name-coupling regression for those setups.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
There are other generated repositories which use this pattern so this concern is already not relevant.
this seems unrelated to my change. |
|
ping @thesayyn |

aspect_bazel_libandpackage_metadataare not visible from the generatedoci_pullrepositories. To resolve this the desired symbols are reexported sooci_pullrepositories only need to resolverules_ociwhich is always guaranteed to work.closes #575