Hook up LLDB debugger backend on linux#2440
Merged
Merged
Conversation
Also fix a couple of compilation issues, with tweaks to the cmake config.
Collaborator
|
This appears to break macOS: |
Collaborator
|
Also I don't think there's a specific reason you needed to introduce a LinuxDebugger.cpp/h, I think it probably would have been best just to put it inside LLDBDebugger but put a conditional '#idef !defined BF_PLATFORM_WINDOWS` around it since that's the only exception to when you would want that code if LLDB_ENABLED were defined. |
Collaborator
|
Oh right there already was a LinuxDebugger. I would suggest deleting that, actually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this the new lldb backend atleast works in linux now.