KS78: Recency tie-breaker for score equality (#13)#28
Open
Conversation
- Add microsecond-precision recency epsilon (step 7c7) after inflation cap so newer memories win ties when final_score values are identical - Fix test matcher for google_result to exclude the Meta memory content (both memories contain "Google", causing ambiguous match) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Liorrr has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
google_resultto exclude the Meta memory (both memories contain "Google", causing ambiguous match)created_at.timestamp_micros() * 1e-18— negligible impact (~3e-5 max) on normal scoring, only breaks tiesTest plan
cargo check -p shrimpk-memory— passescargo clippy -p shrimpk-memory -- -D warnings— cleancargo test -p shrimpk-memory— 391 passed, 0 failed, 21 ignoredcargo check --workspace— all crates compileCloses #13.
Generated with Claude Code