Method extraction cledithighlighter#1558
Open
yakryder wants to merge 2 commits intobenweet:masterfrom
Open
Conversation
Replaces comments, follows example of `highlight/1` in same file
Replaces comments and follows example of `highlight/1` in same file
yakryder
force-pushed
the
method-extraction-cledithighlighter
branch
from
94e058c to
7bb112f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup of #1556.
Comments dup'ed below:
Really simple stuff. For me this is a small improvement, but I'd be interested in some guidance on the intended file organization in general and the function that is currently called removeUnauthorizedSiblingNodesFrom specifically.
If this looks worse to you rather than better it's no problem :)