Skip to content

Prevent user to create/delete folder/files anywhere#3717

Merged
bobvandevijver merged 6 commits into
bolt:6.1from
shirkalab:traversal
May 11, 2026
Merged

Prevent user to create/delete folder/files anywhere#3717
bobvandevijver merged 6 commits into
bolt:6.1from
shirkalab:traversal

Conversation

@kouz75
Copy link
Copy Markdown
Contributor

@kouz75 kouz75 commented May 7, 2026

An authenticated user with managefiles permission could supply a path parameter (e.g.
/../../src) to delete a directories anywhere on the filesystem that the web process can write to.

  • Replace Path::canonicalize() with the project's own PathCanonicalize::canonicalize() in the delete() and create() methods of FilemanagerController

Copy link
Copy Markdown
Member

@bobvandevijver bobvandevijver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kouz75 What's the reason this is draft? By the way, no need to merge 6.1 in on every change, that will come when it is ready to merge 👍🏻

Comment thread src/Controller/Backend/FilemanagerController.php Outdated
@kouz75 kouz75 marked this pull request as ready for review May 10, 2026 09:02
@kouz75 kouz75 requested a review from bobvandevijver May 10, 2026 09:10
@bobvandevijver bobvandevijver merged commit 5b7f93c into bolt:6.1 May 11, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants