fix: validate Buffer type in PutCopyData before calling Buffer::Data#134
Open
MinhyukHong wants to merge 4 commits intobrianc:masterfrom
Open
fix: validate Buffer type in PutCopyData before calling Buffer::Data#134MinhyukHong wants to merge 4 commits intobrianc:masterfrom
MinhyukHong wants to merge 4 commits intobrianc:masterfrom
Conversation
Owner
|
Thanks for submitting this! you'll likely need to add a test for this. Also, I believe you're missing a closing paren? |
Add test for TypeError when non-Buffer is passed to putCopyData
Author
|
Added a test case and fixed the paren. Let me know if anything else is needed! Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$putCopyData() can be called directly on the binding instance, bypassing the instanceof check in the JS wrapper. This adds the same validation at the C++ level so unexpected input throws a TypeError instead of aborting.