Skip to content

Commit 0b80a02

Browse files
authored
Append RUSTFLAGS in CI, don't clobber (#12249)
This fixes an issues where for release binaries we set some `RUSTFLAGS` for some targets but that was getting clobbered by setting `-Dwarnings`. This only affects Windows binaries right now and in theory means that all future Windows binaries will be a bit more portable.
1 parent 218ea9b commit 0b80a02

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

.github/actions/install-rust/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ runs:
5858
EOF
5959
6060
# Deny warnings on CI to keep our code warning-free as it lands in-tree.
61-
echo RUSTFLAGS="-D warnings" >> "$GITHUB_ENV"
61+
echo RUSTFLAGS="-D warnings $RUSTFLAGS" >> "$GITHUB_ENV"
6262
6363
if [[ "${{ runner.os }}" = "macOS" ]]; then
6464
cat >> "$GITHUB_ENV" <<EOF

0 commit comments

Comments
 (0)