Skip to content

feat: Smart/Origin: enable the 'filter with map scale' button#4561

Merged
Nayor merged 1 commit into
masterfrom
smart-origin/garantie1
Mar 18, 2026
Merged

feat: Smart/Origin: enable the 'filter with map scale' button#4561
Nayor merged 1 commit into
masterfrom
smart-origin/garantie1

Conversation

@lgourdin
Copy link
Copy Markdown
Contributor

@lgourdin lgourdin commented Mar 9, 2026

Summary by CodeRabbit

  • New Features

    • Added a new filter control feature to the map interface, enabling users to apply and adjust filters directly while viewing the map.
  • Bug Fixes

    • Improved bbox assignment logic to prevent overwrites of existing boundary parameters in filter operations, resulting in more predictable filtering behavior.

@lgourdin lgourdin changed the title [improve] enable the 'filter with map scale' button [feat] enable the 'filter with map scale' button Mar 9, 2026
@lgourdin lgourdin changed the title [feat] enable the 'filter with map scale' button feat: Smart/Origin: enable the 'filter with map scale' button Mar 9, 2026
@github-actions github-actions Bot added the enhancement New feature or request label Mar 9, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 9, 2026

Walkthrough

A single Vue component is updated to add a show-filter-control prop to the map-view component, enabling optional UI filter control display. Additionally, the filterPostNavitiaDocuments method adds a guard condition to prevent overwriting existing bbox values in the query.

Changes

Cohort / File(s) Summary
Filter Control & Bbox Logic
src/components/itinevert/ItinevertResultView.vue
Added show-filter-control boolean prop to map-view component for conditional filter UI display. Refined filterPostNavitiaDocuments bbox assignment logic with guard clause to prevent overwriting existing bbox properties.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Whiskers twitching with delight,
A filter control takes its flight,
Bbox guards stand tall and true,
No overwriting shall ensue!
Maps now dance with logic bright! 🗺️✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title 'feat: Smart/Origin: enable the 'filter with map scale' button' directly describes the main change: enabling a filter control for map scale functionality, which aligns with the addition of the show-filter-control prop to the map-view component.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch smart-origin/garantie1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Nayor
Copy link
Copy Markdown
Contributor

Nayor commented Mar 12, 2026

OK pour moi 👍

@Nayor Nayor merged commit a77216a into master Mar 18, 2026
10 of 11 checks passed
@Nayor Nayor deleted the smart-origin/garantie1 branch March 18, 2026 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants