refactor(helpers): migrate TutorialTimeRemaining to TypeScript#398
Open
shashankcodes1903 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request migrates the
TutorialTimeRemaininghelper from JavaScript to TypeScript, improving type safety and code reliability.Changes
tutorialTime.jstotutorialTime.tsStepinterface to define the structure of step objects.splice()with.slice()to prevent unintended mutation of the input array.reduce()for improved clarity and functional styleRelated Issue
N/A
Motivation and Context
This change enhances type safety and eliminates potential side effects caused by mutating the original steps array. It also aligns the helper with the project's TypeScript migration efforts and improves overall code readability.
How Has This Been Tested?
npx tsc --noEmitScreenshots or GIF (In case of UI changes):
N/A
Types of changes
Checklist: