Skip to content

fix(sidebar): resolve duplicate keys and correct data-testid usage#399

Open
shashankcodes1903 wants to merge 2 commits into
c2siorg:developfrom
shashankcodes1903:fix/sidebar-keys-and-testid
Open

fix(sidebar): resolve duplicate keys and correct data-testid usage#399
shashankcodes1903 wants to merge 2 commits into
c2siorg:developfrom
shashankcodes1903:fix/sidebar-keys-and-testid

Conversation

@shashankcodes1903
Copy link
Copy Markdown

Description

This pull request resolves React warnings in the sidebar component by ensuring unique keys for list items and correcting invalid DOM attribute usage.

Related Issue

N/A

Motivation and Context

The sidebar component was rendering multiple elements with identical keys, which can lead to incorrect component reconciliation and unpredictable UI behavior. Additionally, the use of an incorrect data-testId attribute triggered React warnings. This change ensures stable rendering and improves code correctness.

How Has This Been Tested?

  • Verified that duplicate key warnings are no longer present in the browser console
  • Confirmed that the data-testid attribute is correctly applied without warnings
  • Ensured no visual or functional regressions in the sidebar component

Screenshots or GIF (In case of UI changes):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shashankcodes1903
Copy link
Copy Markdown
Author

Hi! I'd like to work on this issue. I've already set up CodeLabz locally and the app is running on my machine. Could I please be assigned to this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant