fix: improve typings and remove mypy ignores#93
fix: improve typings and remove mypy ignores#93timl3136 wants to merge 4 commits intocadence-workflow:mainfrom
Conversation
Signed-off-by: Tim Li <ltim@uber.com>
Signed-off-by: Tim Li <ltim@uber.com>
Code Review ✅ Approved 1 resolved / 1 findingsRefactored typings and removed redundant mypy ignores throughout the codebase. The comparison logic in is_retryable was corrected to handle decoded strings instead of bytes constants. ✅ 1 resolved✅ Bug: is_retryable compares decoded str to bytes constant
OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
What changed?
Improve typings and remove mypy ignores, also add clear mypy cache to
make cleancommandWhy?
we should not use ignore to override type safety check.
How did you test it?
only typing improvements
Potential risks
Release notes
Documentation Changes
Summary by Gitar
call_details.methodtobytesinretry.pyto handle runtime type changes ingrpciov1.75.0+.castin test suites to resolve type mismatches inGetWorkflowExecutionHistoryresponses andStartWorkflowOptionsdictionary mocking.This will update automatically on new commits.